dajac commented on PR #18848: URL: https://github.com/apache/kafka/pull/18848#issuecomment-2656619100
> And this is a shortcoming in the KIP I think. Should we include GroupType in a new version of the DeleteGroups RPC? It's unfortunate that this code doesn't know the group type being deleted. It could do. lmk if you want me to address this in the KIP. It would be unfortunate to require the caller to specify the group type. Knowing the group id is everything that the server needs to know in the end. > The deletion of the share group state is scheduled before the call to GroupCoordinatorShard.deleteGroups which actually checks the group type and whether the group is empty. I think that we could consider restructuring the code to start by fetching the groups from the state machines (shards). The response would include whether the groups are eligible to be deleted and their type. Then we could proceed with the flow based on the group type. This would resolve both points. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
