ijuma commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1950991354
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -368,7 +320,8 @@ public static MetadataVersion fromVersionString(String
versionString) {
key = String.join(".", Arrays.copyOfRange(versionSegments, 0,
numSegments));
}
return Optional.ofNullable(IBP_VERSIONS.get(key)).orElseThrow(() ->
- new IllegalArgumentException("Version " + versionString + " is not
a valid version")
+ new IllegalArgumentException("Version " + versionString + " is not
a valid version. The minimum version is " + MINIMUM_VERSION
+ + " and the maximum version is " + latestTesting())
Review Comment:
If you check `MetadataVersion.testFromVersionString`, this code is accurate
- `4.0-IV3` works even though it's a testing version still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
