clolov commented on code in PR #18791:
URL: https://github.com/apache/kafka/pull/18791#discussion_r1942563929
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java:
##########
@@ -97,7 +96,7 @@ public void waitTillConsumptionCatchesUp(RecordMetadata
recordMetadata) throws T
* @param timeoutMs wait timeout in milliseconds
* @throws TimeoutException if this method execution did not complete with
in the given {@code timeoutMs}.
*/
- public void waitTillConsumptionCatchesUp(RecordMetadata recordMetadata,
+ void waitTillConsumptionCatchesUp(RecordMetadata recordMetadata,
long timeoutMs) throws
TimeoutException {
Review Comment:
If we align the indentation of arguments could you align this?
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemotePartitionMetadataStore.java:
##########
@@ -130,20 +130,20 @@ private RemoteLogMetadataCache
getRemoteLogMetadataCache(TopicIdPartition topicI
return remoteLogMetadataCache;
}
- public Optional<RemoteLogSegmentMetadata>
remoteLogSegmentMetadata(TopicIdPartition topicIdPartition,
- long
offset,
- int
epochForOffset)
+ Optional<RemoteLogSegmentMetadata>
remoteLogSegmentMetadata(TopicIdPartition topicIdPartition,
+ long offset,
+ int
epochForOffset)
throws RemoteStorageException {
return
getRemoteLogMetadataCache(topicIdPartition).remoteLogSegmentMetadata(epochForOffset,
offset);
}
- public Optional<RemoteLogSegmentMetadata>
nextSegmentWithTxnIndex(TopicIdPartition topicIdPartition,
- int
epoch,
- long
offset) throws RemoteStorageException {
+ Optional<RemoteLogSegmentMetadata>
nextSegmentWithTxnIndex(TopicIdPartition topicIdPartition,
+ int epoch,
+ long offset)
throws RemoteStorageException {
return
getRemoteLogMetadataCache(topicIdPartition).nextSegmentWithTxnIndex(epoch,
offset);
}
- public Optional<Long> highestLogOffset(TopicIdPartition topicIdPartition,
+ Optional<Long> highestLogOffset(TopicIdPartition topicIdPartition,
int leaderEpoch) throws
RemoteStorageException {
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
