FrankYang0529 commented on code in PR #18330:
URL: https://github.com/apache/kafka/pull/18330#discussion_r1939313578
##########
core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala:
##########
@@ -112,20 +82,18 @@ class SaslApiVersionsRequestTest(cluster: ClusterInstance)
extends AbstractApiVe
assertEquals(Errors.UNSUPPORTED_VERSION.code,
apiVersionsResponse.data.errorCode)
val apiVersionsResponse2 =
IntegrationTestUtils.sendAndReceive[ApiVersionsResponse](
new ApiVersionsRequest.Builder().build(0), socket)
- validateApiVersionsResponse(apiVersionsResponse2,
+ validateApiVersionsResponse(
+ apiVersionsResponse2,
enableUnstableLastVersion = !"false".equals(
-
cluster.config().serverProperties().get("unstable.api.versions.enable")))
+
cluster.config().serverProperties().get("unstable.api.versions.enable")),
+ apiVersion = 0.toShort
+ )
sendSaslHandshakeRequestValidateResponse(socket)
} finally {
socket.close()
}
}
- @AfterEach
- def closeSasl(): Unit = {
- sasl.closeSasl()
Review Comment:
I think we can keep it as current implementation since we have thread leak
detection. We can catch error if there is thread leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
