lucasbru commented on code in PR #18700:
URL: https://github.com/apache/kafka/pull/18700#discussion_r1939033861
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKey.java:
##########
@@ -14,26 +14,25 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.kafka.streams.kstream.internals.foreignkeyjoin;
import java.util.Objects;
-public class CombinedKey<KF, KP> {
- private final KF foreignKey;
- private final KP primaryKey;
+public class CombinedKey<KRight, KLeft> {
Review Comment:
I agree on keeping the order as it is serialized, that's why I said we
shouldn't swap them. I think I have a slight preference for using KForeign and
KPrimary, but I'm also fine with keeping KRight/KLeft. It's true that you can
use the variable names to discern that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
