frankvicky commented on code in PR #18737:
URL: https://github.com/apache/kafka/pull/18737#discussion_r1938207132
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -402,22 +399,20 @@ public void testCommitAsyncWithEmptyOffsets() {
(short) 1,
Errors.NONE)));
- verify(subscriptionState).allConsumed();
verify(metadata).updateLastSeenEpochIfNewer(tp, 1);
assertTrue(future.isDone());
Map<TopicPartition, OffsetAndMetadata> commitOffsets =
assertDoesNotThrow(() -> future.get());
assertEquals(offsets, commitOffsets);
}
@Test
- public void testCommitAsyncWithEmptyAllConsumedOffsets() {
+ public void testCommitAsyncWithEmptyLatestPartitionOffsetsOffsets() {
Review Comment:
related comment:
https://github.com/apache/kafka/pull/18737#discussion_r1938206424
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -414,7 +418,16 @@ private void process(final ResetOffsetEvent event) {
*/
private void process(final CheckAndUpdatePositionsEvent event) {
CompletableFuture<Boolean> future =
requestManagers.offsetsRequestManager.updateFetchPositions(event.deadlineMs());
- future.whenComplete(complete(event.future()));
+ final CompletableFuture<Boolean> b = event.future();
Review Comment:
related comment:
https://github.com/apache/kafka/pull/18737#discussion_r1938206424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
