m1a2st commented on PR #18548: URL: https://github.com/apache/kafka/pull/18548#issuecomment-2618875467
> It appears to me that the reason has to do with the ordering of two RequestManagers. Is it this way because CommitRequestManager.poll() is called before AbstractHeartbeatRequestManager.poll() Yes, this is the main reason. Different RequestManager implementations may need to handle fatal errors differently. Therefore, we moved error handling logic to individual `RequestManager` classes. Since `CommitRequestManager.poll()` executes before `AbstractHeartbeatRequestManager.poll()`, I chose to clear fatal errors in `AbstractHeartbeatRequestManager`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
