ppkarwasz commented on code in PR #18496:
URL: https://github.com/apache/kafka/pull/18496#discussion_r1931138996
##########
core/src/main/scala/kafka/utils/Logging.scala:
##########
@@ -24,13 +24,19 @@ import org.slf4j.{LoggerFactory, Marker, MarkerFactory}
object Log4jControllerRegistration {
private val logger = Logger(this.getClass.getName)
- try {
- val log4jController =
Class.forName("kafka.utils.Log4jController").asInstanceOf[Class[Object]]
- val instance = log4jController.getDeclaredConstructor().newInstance()
- CoreUtils.registerMBean(instance, "kafka:type=kafka.Log4jController")
- logger.info("Registered kafka:type=kafka.Log4jController MBean")
- } catch {
- case _: Exception => logger.info("Couldn't register
kafka:type=kafka.Log4jController MBean")
+ private val loggingMBean = new LoggingController
+ // Legacy name
+ registerMBean(loggingMBean, "kafka.Log4jController")
+ // New name
+ registerMBean(loggingMBean, "kafka.LoggingController")
Review Comment:
Fixed in
https://github.com/apache/kafka/pull/18496/commits/3922eff91d7778c02bd0f1d1ebfb642a9daffd8c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
