chia7712 commented on code in PR #18609:
URL: https://github.com/apache/kafka/pull/18609#discussion_r1931114177
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##########
@@ -149,7 +149,7 @@ public void
testConsumerGroupServiceWithAuthenticationFailure(String quorum, Str
}
@ParameterizedTest(name = "{displayName}.quorum={0}.groupProtocol={1}")
-
@MethodSource("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly")
+ @MethodSource("getTestQuorumAndGroupProtocolParametersAll")
public void testConsumerGroupServiceWithAuthenticationSuccess(String
quorum, String groupProtocol) throws Exception {
createScramCredentialsViaPrivilegedAdminClient(JaasTestUtils.KAFKA_SCRAM_USER_2,
JaasTestUtils.KAFKA_SCRAM_PASSWORD_2);
ConsumerGroupCommand.ConsumerGroupService consumerGroupService =
prepareConsumerGroupService();
Review Comment:
ditto
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##########
@@ -136,7 +136,7 @@ public void tearDown() {
// NOTE: Not able to refer TestInfoUtils#TestWithParameterizedQuorumName()
in the ParameterizedTest name.
@ParameterizedTest(name = "{displayName}.quorum={0}.groupProtocol={1}")
-
@MethodSource("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly")
+ @MethodSource("getTestQuorumAndGroupProtocolParametersAll")
public void testConsumerGroupServiceWithAuthenticationFailure(String
quorum, String groupProtocol) throws Exception {
ConsumerGroupCommand.ConsumerGroupService consumerGroupService =
prepareConsumerGroupService();
Review Comment:
As we are modifying this PR, could you please close `consumerGroupService`
via `try-release` also? For example:
```java
try (ConsumerGroupCommand.ConsumerGroupService consumerGroupService
= prepareConsumerGroupService();
Consumer<byte[], byte[]> consumer = createConsumer()) {
consumer.subscribe(Collections.singletonList(TOPIC));
verifyAuthenticationException(consumerGroupService::listGroups);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
