dongnuo123 commented on code in PR #18717:
URL: https://github.com/apache/kafka/pull/18717#discussion_r1931020413


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetricsShard.java:
##########
@@ -71,7 +71,7 @@ public TimelineGaugeCounter(TimelineLong timelineLong, 
AtomicLong atomicLong) {
     /**
      * Consumer group size gauge counters keyed by the metric name.
      */
-    private final Map<ConsumerGroupState, TimelineGaugeCounter> 
consumerGroupGauges;
+    private volatile Map<ConsumerGroupState, Long> consumerGroupGauges;

Review Comment:
   Removed the timeline gauge counter because we recompute the metric from 
scratch every 60 second, so the result will always be consistent despite any 
rollbacks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to