smjn commented on code in PR #18712: URL: https://github.com/apache/kafka/pull/18712#discussion_r1930762085
########## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ########## @@ -10513,6 +10513,96 @@ class KafkaApisTest extends Logging { }) } + @Test Review Comment: If share coordinator is not enabled - this call can never be made since this is an inter broker RPC and share coordinator being unavailable means the Persister implementation will never default to DefaultStatePersister and will be a NoOpStatePersister thus, this scenario does not come up. Added for completeness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org