lianetm commented on PR #18590: URL: https://github.com/apache/kafka/pull/18590#issuecomment-2613396568
Hey @frankvicky, good finding. Agree that the behaviour is not aligned in the close timeout handling, so in practice the classic consumer.close will never wait for more than the request timeout if there is a call to close with a larger timeout (and that's indeed missing on the async close timeout) Actually, the behaviour is explicitly called out in one of the tests: https://github.com/lianetm/kafka/blob/023f9c26e60c0710891abd148cce52c1dadaf7cd/core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala#L300-L305 So I do agree that we need to align this. But just for my understanding, this is something else we need here to unblock these tests (the `testClose` specifically I imagine?), but not enough right? I expect we still need to deal with the initial situation to avoid issuing/blocking on unneeded FindCoord requests on close after the commit/leave have completed, agree? (just to make sure I'm not missing anything). If my understanding is right then I think we should file a separate jira for the close timeout considering the request timeout, and if you can validate locally that it's the only fix required to enable the `testClose` then we enable it in that other PR (leaving this PR for the unneeded FindCoord issue and the `testCloseDuringRebalance`), let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
