lianetm commented on code in PR #18668: URL: https://github.com/apache/kafka/pull/18668#discussion_r1928895890
########## core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala: ########## @@ -112,7 +112,7 @@ class SaslClientsWithInvalidCredentialsTest extends AbstractSaslTest { } @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames) - @MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly")) + @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll")) def testTransactionalProducerWithAuthenticationFailure(quorum: String, groupProtocol: String): Unit = { Review Comment: should we better remove the `groupProtocol` param given that it does not apply here? (and parametrize the test with the quorum only) ``` @ParameterizedTest @ValueSource(strings = Array("kraft")) ``` ########## core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala: ########## @@ -154,11 +154,11 @@ class SaslClientsWithInvalidCredentialsTest extends AbstractSaslTest { createClientCredential() val producer = createProducer() verifyWithRetry(sendOneRecord(producer)) - verifyWithRetry(assertEquals(1, consumer.poll(Duration.ofMillis(1000)).count)) + verifyWithRetryPredicate(consumer.poll(Duration.ofMillis(1000)).count == 1) } @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames) - @MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly")) + @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll")) def testKafkaAdminClientWithAuthenticationFailure(quorum: String, groupProtocol: String): Unit = { Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org