dajac commented on PR #18667: URL: https://github.com/apache/kafka/pull/18667#issuecomment-2609883059
> > Should we still change this [line](https://github.com/apache/kafka/blob/32f0dbbbfd9aa079bfbaa21280563bf62b56a5f4/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java#L2423) to ensure that the context is always removed no matter what? > > I don't think it's wholly necessary if we are convinced that `unload()` won't throw. We could do it as a defensive measure I guess? Yeah, it is indeed a defensive measure. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org