chia7712 commented on code in PR #18632: URL: https://github.com/apache/kafka/pull/18632#discussion_r1926836106
########## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ########## @@ -793,6 +793,7 @@ class ReplicaManagerTest { try { val brokerList = Seq[Integer](0, 1).asJava + when(replicaManager.metadataCache.getAliveBrokerEpoch(1)).thenReturn(Some(brokerEpoch)) Review Comment: Could you please move the mock to line#3154? We should mock the method after creating the mocked `metadataCache` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org