[ 
https://issues.apache.org/jira/browse/KAFKA-18489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914711#comment-17914711
 ] 

Mickael Maison commented on KAFKA-18489:
----------------------------------------

If the metrics are not working anymore then this is a bug. It seems you've 
looked into the issue, can you open a PR?

> Connector tasks metrics task-startup-attempts, task-startup-success are not 
> being updated
> -----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-18489
>                 URL: https://issues.apache.org/jira/browse/KAFKA-18489
>             Project: Kafka
>          Issue Type: Bug
>          Components: connect
>    Affects Versions: 3.3.0, 3.4.0, 3.5.0, 3.6.0, 3.7.0, 3.8.0, 3.9.0
>            Reporter: Ashwin Pankaj
>            Assignee: Ashwin Pankaj
>            Priority: Minor
>         Attachments: image-2025-01-13-17-17-12-700.png
>
>
> A minor bug was introduced as part of [EOS in Apache Kafka 3 years 
> ago|https://github.com/apache/kafka/commit/9e8ef8bb317599c184ce8201d494edf109d9c528#diff-90b4072cc070e1d6417b3bb59a4a35668c4d97ce1dd6a2587db9f2c9a9ebf93e]
>  The line
> {{final TaskStatus.Listener taskStatusListener = 
> workerMetricsGroup.wrapStatusListener(statusListener);}}
> {{ }}
> {{wraps herder's listener in workerMetricsGroup's listener. 
> WorkerMetricsGroup is the entity which records task success and failure in 
> the metric .}}
> {{In the PR, the wrapped listener was missed and instead the herder listener 
> is passed to the task builder (as part of constructor).}}
> {{ }}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to