mimaison commented on code in PR #18346:
URL: https://github.com/apache/kafka/pull/18346#discussion_r1920064952


##########
server/src/main/java/org/apache/kafka/server/config/ServerConfigs.java:
##########
@@ -46,9 +46,7 @@ public class ServerConfigs {
 
     public static final String BROKER_ID_CONFIG = "broker.id";
     public static final int BROKER_ID_DEFAULT = -1;
-    public static final String BROKER_ID_DOC = "The broker id for this server. 
If unset, a unique broker id will be generated." +
-            "To avoid conflicts between ZooKeeper generated broker id's and 
user configured broker id's, generated broker ids " +
-            "start from " + RESERVED_BROKER_MAX_ID_CONFIG + " + 1.";
+    public static final String BROKER_ID_DOC = "The broker id for this server. 
If unset, a unique broker id will be generated.";

Review Comment:
   I don't think this is correct. In KRaft mode, broker ids are not generated.



##########
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##########
@@ -77,7 +77,7 @@ public class SocketServerConfigs {
     public static final String ADVERTISED_LISTENERS_CONFIG = 
"advertised.listeners";
     public static final String ADVERTISED_LISTENERS_DOC = 
String.format("Specifies the listener addresses that the Kafka brokers will 
advertise to clients and other brokers." +
                     " The config is useful where the actual listener 
configuration <code>%s</code> does not represent the addresses that clients 
should" +
-                    " use to connect, such as in cloud environments. In 
environments using ZooKeeper, these addresses are published to ZooKeeper." +
+                    " use to connect, such as in cloud environments." +

Review Comment:
   Can we rephrase the next sentence?
   For example:
   ```
   The address would be published to and managed by the KRaft controller, the 
brokers pull these data from the controller as needed.
   ```



##########
server/src/main/java/org/apache/kafka/server/config/KRaftConfigs.java:
##########
@@ -36,29 +36,27 @@
 public class KRaftConfigs {
     /** KRaft mode configs */
     public static final String PROCESS_ROLES_CONFIG = "process.roles";
-    public static final String PROCESS_ROLES_DOC = "The roles that this 
process plays: 'broker', 'controller', or 'broker,controller' if it is both. " +
-            "This configuration is only applicable for clusters in KRaft 
(Kafka Raft) mode (instead of ZooKeeper). Leave this config undefined or empty 
for ZooKeeper clusters.";
-
+    public static final String PROCESS_ROLES_DOC = "The roles that this 
process plays: 'broker', 'controller', or 'broker,controller' if it is both. ";
+    
     public static final String INITIAL_BROKER_REGISTRATION_TIMEOUT_MS_CONFIG = 
"initial.broker.registration.timeout.ms";
     public static final int INITIAL_BROKER_REGISTRATION_TIMEOUT_MS_DEFAULT = 
60000;
     public static final String INITIAL_BROKER_REGISTRATION_TIMEOUT_MS_DOC = 
"When initially registering with the controller quorum, the number of 
milliseconds to wait before declaring failure and exiting the broker process.";
 
     public static final String BROKER_HEARTBEAT_INTERVAL_MS_CONFIG = 
"broker.heartbeat.interval.ms";
     public static final int BROKER_HEARTBEAT_INTERVAL_MS_DEFAULT = 2000;
-    public static final String BROKER_HEARTBEAT_INTERVAL_MS_DOC = "The length 
of time in milliseconds between broker heartbeats. Used when running in KRaft 
mode.";
+    public static final String BROKER_HEARTBEAT_INTERVAL_MS_DOC = "The length 
of time in milliseconds between broker heartbeats.";
 
     public static final String BROKER_SESSION_TIMEOUT_MS_CONFIG = 
"broker.session.timeout.ms";
     public static final int BROKER_SESSION_TIMEOUT_MS_DEFAULT = 9000;
-    public static final String BROKER_SESSION_TIMEOUT_MS_DOC = "The length of 
time in milliseconds that a broker lease lasts if no heartbeats are made. Used 
when running in KRaft mode.";
+    public static final String BROKER_SESSION_TIMEOUT_MS_DOC = "The length of 
time in milliseconds that a broker lease lasts if no heartbeats are made.";
 
 
     public static final String NODE_ID_CONFIG = "node.id";
     public static final int EMPTY_NODE_ID = -1;
-    public static final String NODE_ID_DOC = "The node ID associated with the 
roles this process is playing when <code>process.roles</code> is non-empty. " +
-            "This is required configuration when running in KRaft mode.";
+    public static final String NODE_ID_DOC = "The node ID associated with the 
roles this process is playing when <code>process.roles</code> is non-empty.";
 

Review Comment:
   I agree



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to