ijuma commented on code in PR #18567:
URL: https://github.com/apache/kafka/pull/18567#discussion_r1919541585
##########
server-common/src/main/java/org/apache/kafka/server/config/ConfigType.java:
##########
@@ -31,6 +31,5 @@ public class ConfigType {
public static final String CLIENT_METRICS = "client-metrics";
public static final String GROUP = "groups";
- // Do not include ClientMetrics and Groups in `all` as they are not
supported on ZK.
Review Comment:
Making it an enum is fine, but can also be done separately. We can file that
as a JIRA if we want to decouple from this PR. The reason why I raised the
issue is that by removing the comment that was there, we had lost track of the
reason for the unusual behavior (which is no longer needed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
