m1a2st commented on code in PR #18510:
URL: https://github.com/apache/kafka/pull/18510#discussion_r1914925979
##########
tools/src/main/java/org/apache/kafka/tools/consumer/ApiMessageFormatter.java:
##########
@@ -79,5 +79,5 @@ public void writeTo(ConsumerRecord<byte[], byte[]>
consumerRecord, PrintStream o
}
protected abstract JsonNode readToKeyJson(ByteBuffer byteBuffer);
- protected abstract JsonNode readToValueJson(ByteBuffer byteBuffer);
-}
+ protected abstract JsonNode readToValueJson(ByteBuffer byteBuffer, short
keyVersion);
Review Comment:
I propose changing the `JsonNode readToValueJson` signature to accept a
`ConsumerRecord<byte[], byte[]>`parameter. This would standardize the method
signature across all subclasses. WDYT?
```
protected JsonNode readToValueJson(ConsumerRecord<byte[], byte[]>
consumerRecord)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
