ahuang98 commented on code in PR #17930: URL: https://github.com/apache/kafka/pull/17930#discussion_r1913959235
########## raft/src/main/java/org/apache/kafka/raft/RaftUtil.java: ########## @@ -546,8 +546,6 @@ public static AddRaftVoterResponseData addVoterResponse( Errors error, String errorMessage ) { - errorMessage = errorMessage == null ? error.message() : errorMessage; Review Comment: otherwise we lose information, e.g. in this case ``` resetAddVoterHandlerState(Errors.REQUEST_TIMED_OUT, null, Optional.empty()); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org