chia7712 commented on code in PR #18386:
URL: https://github.com/apache/kafka/pull/18386#discussion_r1913209026
##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -781,7 +781,8 @@ def prop_file(self, node):
#update template configs with test override configs
configs.update(override_configs)
- prop_file = self.render_configs(configs)
+ filtered_configs = {k: v for k, v in configs.items() if v not in
[None, ""]}
Review Comment:
Please add this behavior to the document (line#258)
##########
tests/kafkatest/tests/core/kraft_upgrade_test.py:
##########
@@ -138,14 +138,22 @@ def run_upgrade_downgrade(self, starting_kafka_version):
- Perform rolling downgrade.
- Finally, validate that every message acked by the producer was
consumed by the consumer.
"""
+
+ # Due to 3.3 compatability issue we need to set one folder
Review Comment:
Could you please revise the comment with more details?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
