lianetm commented on code in PR #18050:
URL: https://github.com/apache/kafka/pull/18050#discussion_r1911403443
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManagerTest.java:
##########
@@ -253,6 +236,21 @@ public void testNetworkTimeout() {
res2 = coordinatorManager.poll(time.milliseconds());
assertEquals(1, res2.unsentRequests.size());
}
+
+ @Test
Review Comment:
what about parametrizing this test to cover retriable errors in the
following response?
`@EnumSource(value = Errors.class, names = {"NONE",
"COORDINATOR_NOT_AVAILABLE"})`, and pass that error arg on ln 251.
The behaviour regarding the clear fatal error should be the same when the
next response is successful or retriable, so I expect the test should apply to
both params without changes
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -1246,6 +1248,16 @@ private List<NetworkClientDelegate.UnsentRequest>
drainPendingCommits() {
clearAll();
return res;
}
+
+ private void maybeFailCoordinatorFatalError() {
Review Comment:
```suggestion
private void maybeFailOnCoordinatorFatalError() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
