pramithas opened a new pull request, #18482:
URL: https://github.com/apache/kafka/pull/18482

   With this change, I have re-ordered the validations when validating the 
sanity of TimeIndex such that the expensive ones are performed at the end. 
   
   E.g.  A read from mmap is more expensive compared to the others. In best 
case scenarios, mmap is completely mapped to memory and hence, the lookup is 
cheap but in worst case scenario, OS will load the data we want to read from 
mmap on-demand. 
   
   Hence, it is moved to the last.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to