kirktrue commented on PR #17669: URL: https://github.com/apache/kafka/pull/17669#issuecomment-2581600523
> Thanks for the updates @kirktrue! One comment left, since the consumer_test.py is now migrated to use kraft, do we still need the num_zk=1 param it's setting on init (ln 32 and 553)? That's a great question! I took a look at the prevalence of the use of `num_zk` and I found quite a few system tests that still specify it: - `tests/kafkatest/benchmarks/core/benchmark_test.py` - `tests/kafkatest/tests/client/consumer_protocol_migration_test.py` - `tests/kafkatest/tests/client/consumer_rolling_upgrade_test.py` - `tests/kafkatest/tests/client/consumer_test.py` - `tests/kafkatest/tests/client/consumer_test.py` - `tests/kafkatest/tests/client/pluggable_test.py` - `tests/kafkatest/tests/client/truncation_test.py` - `tests/kafkatest/tests/connect/connect_distributed_test.py` - `tests/kafkatest/tests/connect/connect_plugin_discovery_test.py` - `tests/kafkatest/tests/connect/connect_rest_test.py` - `tests/kafkatest/tests/kafka_test.py` - `tests/kafkatest/tests/streams/streams_eos_test.py` - `tests/kafkatest/tests/streams/streams_relational_smoke_test.py` - `tests/kafkatest/tests/streams/streams_shutdown_deadlock_test.py` - `tests/kafkatest/tests/streams/streams_smoke_test.py` - `tests/kafkatest/tests/tools/log_compaction_test.py` - `tests/kafkatest/tests/tools/replica_verification_test.py` So my question would be: do I change just the occurrences in _this test_, all the occurrences in the _client tests_, or all _tests_? What's your preference? > Also, could you share a run with the latest changes to double check we're not missing anything. Thanks! Done! I updated the links in the main description with the latest run from yesterday (January 8, 2025). Note that there are a handful of lingering quota-related test failures, but they occur up in both `trunk` and in this branch. These test failures have been around for some time, sadly (KAFKA-16138). In my estimation they're unrelated, but I'd like to hear your take. Thanks @lianetm! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
