apoorvmittal10 commented on code in PR #18408: URL: https://github.com/apache/kafka/pull/18408#discussion_r1909562685
########## storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java: ########## @@ -77,7 +76,6 @@ private BrokerTopicMetrics(Optional<String> name, boolean remoteStorageEnabled) metricTypeMap.put(FAILED_FETCH_REQUESTS_PER_SEC, new MeterWrapper(FAILED_FETCH_REQUESTS_PER_SEC, "requests")); metricTypeMap.put(TOTAL_PRODUCE_REQUESTS_PER_SEC, new MeterWrapper(TOTAL_PRODUCE_REQUESTS_PER_SEC, "requests")); metricTypeMap.put(TOTAL_FETCH_REQUESTS_PER_SEC, new MeterWrapper(TOTAL_FETCH_REQUESTS_PER_SEC, "requests")); - metricTypeMap.put(FETCH_MESSAGE_CONVERSIONS_PER_SEC, new MeterWrapper(FETCH_MESSAGE_CONVERSIONS_PER_SEC, "requests")); Review Comment: @chia7712 I have removed the code from KafkaApis as it's of no use but kept the metric so it could be reported, verified using jconsole. I have added deprecated messaes to ops.html and upgrade.html. I have marked both Produce and Fetch as deprecated since we will be removing unnecessary code for up-conversion as well, is that right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org