chia7712 commented on code in PR #18382: URL: https://github.com/apache/kafka/pull/18382#discussion_r1908464125
########## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/fetcher/ReplicaFetcherThreadBenchmark.java: ########## @@ -127,18 +119,16 @@ public class ReplicaFetcherThreadBenchmark { @Setup(Level.Trial) public void setup() throws IOException { - if (!logDir.mkdir()) - throw new IOException("error creating test directory"); - scheduler.startup(); - Properties props = new Properties(); - props.put("zookeeper.connect", "127.0.0.1:9999"); - KafkaConfig config = new KafkaConfig(props); + KafkaConfig config = KafkaConfig.fromProps(TestUtils.createBrokerConfig( Review Comment: @FrankYang0529 could you please fix the build error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org