peterxcli commented on code in PR #18337:
URL: https://github.com/apache/kafka/pull/18337#discussion_r1907703362


##########
test-common/test-common-api/src/test/java/org/apache/kafka/common/test/api/ClusterTestExtensionsTest.java:
##########
@@ -347,6 +349,20 @@ public void testControllerListenerName(ClusterInstance 
cluster) throws Execution
         }
     }
 
+    @ClusterTest(types = {Type.KRAFT})
+    public void testControllerRestart(ClusterInstance cluster) throws 
ExecutionException, InterruptedException {
+        try (Admin admin = cluster.admin()) {
+
+            ControllerServer controller = 
cluster.controllers().values().iterator().next();
+            controller.shutdown();
+            controller.awaitShutdown();

Review Comment:
   Thanks for asking, 
   The broker won't be fixed in this change, I have also filed another 
[PR](https://github.com/apache/kafka/pull/18381) to address it, and 
[this](https://github.com/apache/kafka/pull/18381/files#diff-42662495d5677aad96a66e3a10bf744a5b22d59078d4bcdc28df663557d336d8R242-R244)
 is the core change to fix the broker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to