chia7712 commented on code in PR #18329:
URL: https://github.com/apache/kafka/pull/18329#discussion_r1899609380
##########
core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala:
##########
@@ -51,7 +51,7 @@ object SaslApiVersionsRequestTest {
// Configure control plane listener to make sure we have separate
listeners for testing.
val serverProperties = new java.util.HashMap[String, String]()
-
serverProperties.put(SocketServerConfigs.CONTROL_PLANE_LISTENER_NAME_CONFIG,
controlPlaneListenerName)
+//
serverProperties.put(SocketServerConfigs.CONTROL_PLANE_LISTENER_NAME_CONFIG,
controlPlaneListenerName)
Review Comment:
I guess we can cleanup this class as well?
##########
core/src/main/scala/kafka/network/SocketServer.scala:
##########
@@ -321,7 +266,7 @@ class SocketServer(
if (acceptor != null) {
acceptor.localPort
} else {
- controlPlaneAcceptorOpt.map(_.localPort).getOrElse(throw new
KafkaException("Could not find listenerName : " + listenerName + " in
data-plane or control-plane"))
+ throw new KafkaException("Could not find listenerName : " +
listenerName + " in data-plane or control-plane")
Review Comment:
please remove `control-plane`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
