ijuma commented on code in PR #18290:
URL: https://github.com/apache/kafka/pull/18290#discussion_r1896350581
##########
build.gradle:
##########
@@ -1881,28 +1901,26 @@ project(':clients') {
implementation libs.zstd
implementation libs.lz4
implementation libs.snappy
- implementation libs.slf4jApi
implementation libs.opentelemetryProto
implementation libs.protobuf
+ implementation log4jLibs
Review Comment:
Hmm, clients and streams should not have any log dependency besides slf4j.
The idea is that client modules shouldn't include logging implementations while
server modules should. Client modules run alongside user applications and the
logging library should be aligned with the application logging library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
