ahuang98 commented on code in PR #17807:
URL: https://github.com/apache/kafka/pull/17807#discussion_r1878925723
##########
raft/src/main/java/org/apache/kafka/raft/ResignedState.java:
##########
@@ -140,10 +140,21 @@ public List<ReplicaKey> preferredSuccessors() {
}
@Override
- public boolean canGrantVote(ReplicaKey candidateKey, boolean
isLogUpToDate) {
+ public boolean canGrantVote(ReplicaKey replicaKey, boolean isLogUpToDate) {
log.debug(
- "Rejecting vote request from candidate ({}) since we have resigned
as candidate/leader in epoch {}",
- candidateKey,
+ "Rejecting Vote request from candidate ({}) since we have resigned
as leader in epoch {}",
+ replicaKey,
+ epoch
+ );
+
+ return false;
+ }
+
+ @Override
+ public boolean canGrantPreVote(ReplicaKey replicaKey, boolean
isLogUpToDate) {
Review Comment:
we did, I updated the KIP description but not the code for this case, thanks
for the catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
