AndrewJSchofield commented on code in PR #18017:
URL: https://github.com/apache/kafka/pull/18017#discussion_r1875032057
##########
core/src/main/java/kafka/server/TierStateMachine.java:
##########
@@ -229,12 +229,8 @@ private Long buildRemoteLogAuxState(TopicPartition
topicPartition,
}
RemoteLogSegmentMetadata remoteLogSegmentMetadata =
rlm.fetchRemoteLogSegmentMetadata(topicPartition, targetEpoch,
previousOffsetToLeaderLocalLogStartOffset)
- .orElseThrow(() -> new RemoteStorageException("Couldn't build
the state from remote store for partition: " + topicPartition +
- ", currentLeaderEpoch: " + currentLeaderEpoch +
- ", leaderLocalLogStartOffset: " +
leaderLocalLogStartOffset +
- ", leaderLogStartOffset: " + leaderLogStartOffset +
- ", epoch: " + targetEpoch +
- "as the previous remote log segment metadata was not
found"));
+ .orElseThrow(() -> buildRemoteStorageException(topicPartition,
targetEpoch, currentLeaderEpoch,
+ leaderLocalLogStartOffset,
previousOffsetToLeaderLocalLogStartOffset));
Review Comment:
It seems to me that the final argument here should be `leaderLogStartOffset`
to match the previous behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
