smjn commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1871540470
##########
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##########
@@ -165,4 +166,21 @@ class CoordinatorPartitionWriter(
// Required offset.
partitionResult.lastOffset + 1
}
+
+ override def deleteRecords(tp: TopicPartition, deleteBeforeOffset: Long):
Unit = {
+ var deleteResults: Map[TopicPartition, DeleteRecordsPartitionResult] =
Map.empty
+ replicaManager.deleteRecords(
+ timeout = 0L,
Review Comment:
This is the same as append records
https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala#L144
will add 30 second timeout nevertheless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
