dajac commented on code in PR #18020:
URL: https://github.com/apache/kafka/pull/18020#discussion_r1870871620
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1685,43 +1702,17 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, CoordinatorRecord>
// The subscription metadata is updated in two cases:
// 1) The member has updated its subscriptions;
// 2) The refresh deadline has been reached.
- Map<String, Integer> subscribedTopicNamesMap =
group.computeSubscribedTopicNames(
+ UpdateSubscriptionMetadataResult result =
updateSubscriptionMetadata(
Review Comment:
This is a small refactoring to share more code between the consumer and the
classic groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
