gharris1727 commented on code in PR #18027:
URL: https://github.com/apache/kafka/pull/18027#discussion_r1870125112


##########
README.md:
##########
@@ -1,55 +1,105 @@
-Apache Kafka
-=================
-See our [web site](https://kafka.apache.org) for details on the project.
-
-You need to have 
[Java](http://www.oracle.com/technetwork/java/javase/downloads/index.html) 
installed.
-
-We build and test Apache Kafka with 17 and 23. The `release` parameter in 
javac and scalac is set to `11` for the clients 
-and streams modules, and `17` for the broker and tools, ensuring compatibility 
with their respective minimum Java versions. 
-
-Scala 2.13 is the only supported version in Apache Kafka.
-
-### Build a jar and run it ###
+# Apache Kafka
+
+<a href="https://kafka.apache.org/";>
+<picture>
+  <source media="(prefers-color-scheme: dark)" 
srcset="docs/images/kafka-logo-readme-dark.svg">
+  <source media="(prefers-color-scheme: light)" 
srcset="docs/images/kafka-logo-readme-light.svg">
+  <img alt="Kafka Logo" src="docs/images/kafka-logo-readme-light.svg" 
width="80"> 
+</picture>
+</a>
+<br><br>
+
+* [Building Kafka](#building-kafka)

Review Comment:
   I don't believe this TOC is worth the screen space. GitHub already has a 
first-class TOC feature, see here:
   ![Picture of existing 
README.md](https://github.com/user-attachments/assets/90ca2ff0-8289-4770-ac08-a8fcfa1ef29f)
   
   The new TOC pushes all of the real content on the page "below the fold", 
making the document much less appealing to read.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to