adixitconfluent commented on code in PR #17957:
URL: https://github.com/apache/kafka/pull/17957#discussion_r1868172271
##########
share/src/main/java/org/apache/kafka/server/share/persister/Persister.java:
##########
@@ -40,15 +40,15 @@ public interface Persister {
* @param request Request parameters
* @return A {@link CompletableFuture} that completes with the result.
*/
- CompletableFuture<ReadShareGroupStateResult>
readState(ReadShareGroupStateParameters request) throws
IllegalArgumentException;
+ CompletableFuture<ReadShareGroupStateResult>
readState(ReadShareGroupStateParameters request);
/**
* Write share-partition state.
*
* @param request Request parameters
* @return A {@link CompletableFuture} that completes with the result.
*/
- CompletableFuture<WriteShareGroupStateResult>
writeState(WriteShareGroupStateParameters request) throws
IllegalArgumentException;
Review Comment:
thanks @chia7712, created issue
https://issues.apache.org/jira/browse/KAFKA-18148, I think we can target it for
4.1 since these APIs are not implemented yet in `DefaultStatePersister`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
