aliehsaeedii commented on code in PR #16218:
URL: https://github.com/apache/kafka/pull/16218#discussion_r1867980314
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/ForeignTableJoinProcessorSupplier.java:
##########
@@ -111,34 +110,26 @@ public void process(final Record<KO, Change<VO>> record) {
return;
}
- final Bytes prefixBytes = keySchema.prefixBytes(record.key());
+ final Bytes foreignKeyBytes = keySchema.prefixBytes(record.key());
//Perform the prefixScan and propagate the results
try (final KeyValueIterator<Bytes,
ValueAndTimestamp<SubscriptionWrapper<K>>> prefixScanResults =
- subscriptionStore.range(prefixBytes,
Bytes.increment(prefixBytes))) {
+ subscriptionStore.prefixScan(foreignKeyBytes, new
BytesSerializer())) {
Review Comment:
I am sorry @Chuckame. I wanted to ping you and mistakenly `AyoubOm` was
pinged. I am only communicating with you here since you are the PR owner. When
I noticed my mistake, I put you in cc, but you are right. I should've edited my
comment. I usually try not to do that but in this case, it was really needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
