[ 
https://issues.apache.org/jira/browse/KAFKA-18132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902609#comment-17902609
 ] 

Chia-Ping Tsai commented on KAFKA-18132:
----------------------------------------

{quote}
"when migrating to AsyncConsumer", this should never impact users of Kafka 
Connect.
{quote}

That's a valid point. Currently, for consumer migration, users need to add the 
configuration `group.protocol=consumer` to use the AsyncConsumer explicitly. 
This requirement is why users are expected to explicitly remove any unexpected 
configurations too.

{quote}
I just tested on trunk and Connect runs fine when session.timeout.ms set. So 
I'm guessing it's the testing code that does something weird and creates 
consumers with that configuratio
{quote}

Could you please share the consumer configurations with me? In this end-to-end 
test, the Connect server is run with the `consumer.session.timeout.ms` 
configuration, causing all consumers to be configured with `session.timeout.ms`.


> Remove "session.timeout.ms" from connect-distributed.properties to fix 
> connect e2e
> ----------------------------------------------------------------------------------
>
>                 Key: KAFKA-18132
>                 URL: https://issues.apache.org/jira/browse/KAFKA-18132
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: 黃竣陽
>            Priority: Major
>
> KAFKA-17338 added configs check for consumer protocol, and 
> `session.timeout.ms` is one of unsupported configs. However, connect.py 
> always load `connect-distributed.properties` to add custom configs and 
> unfortunately it includes `session.timeout.ms`  ...
> In fact, the default value is already 10 secs 
> (https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java#L320).
>  That means we don't need to configure the value by the config files.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to