ableegoldman commented on code in PR #17929:
URL: https://github.com/apache/kafka/pull/17929#discussion_r1867470527
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KGroupedStreamImpl.java:
##########
@@ -184,7 +184,7 @@ private KTable<K, Long> doCount(final Named named, final
Materialized<K, Long, K
final String name = new
NamedInternal(named).orElseGenerateWithPrefix(builder, AGGREGATE_NAME);
return doAggregate(
- new KStreamAggregate<>(materializedInternal.storeName(),
aggregateBuilder.countInitializer, aggregateBuilder.countAggregator),
+ new KStreamAggregate<>(materializedInternal,
aggregateBuilder.countInitializer, aggregateBuilder.countAggregator),
Review Comment:
wait sorry, I was thinking of something else -- the StatefulProcessorNode
does already have an alternative constructor we can use for nodes that
add/connect their stores on their own. So yeah, we can go ahead and use that
one now so the StatefulProcessorNode doesn't add the store twice (even if it's
not problematic to do so)
Opened a quick hotfix PR for this: https://github.com/apache/kafka/pull/18015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
