OmniaGM commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r1867110442
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -727,6 +732,27 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ def getPartitionOrException(topicIdPartition: TopicIdPartition): Partition =
{
Review Comment:
The original name of this method that accept `topicPartition` is
`getPartitionOrException` I feel it would be weird to name this
`partitionOrException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
