apoorvmittal10 commented on PR #17957: URL: https://github.com/apache/kafka/pull/17957#issuecomment-2512555509
> > Hi @apoorvmittal10 , i have addressed your comments where you mentioned to decouple the locks in both maybeInitialize and post persister write state RPC calls. @chia7712 is mentioning about this comment thread [#17957 (comment)](https://github.com/apache/kafka/pull/17957#discussion_r1862570482) where we've not reached consensus that we want to separate out the future completion from the lock scope. Other than that, all the changes are done. I would like to merge this PR since other comments have been resolved and it would be good if we can reach consensus on the former thread, so if needed, I can make the changes before the feature freeze. Thanks, left a comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org