chia7712 commented on code in PR #17099:
URL: https://github.com/apache/kafka/pull/17099#discussion_r1863883205
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerInterceptor.java:
##########
@@ -81,12 +82,40 @@ public interface ProducerInterceptor<K, V> extends
Configurable, AutoCloseable {
* @param metadata The metadata for the record that was sent (i.e. the
partition and offset).
* If an error occurred, metadata will contain only valid
topic and maybe
* partition. If partition is not given in ProducerRecord
and an error occurs
- * before partition gets assigned, then partition will be
set to RecordMetadata.NO_PARTITION.
+ * before partition gets assigned, then partition will be
set to RecordMetadata.UNKNOWN_PARTITION.
* The metadata may be null if the client passed null
record to
* {@link
org.apache.kafka.clients.producer.KafkaProducer#send(ProducerRecord)}.
* @param exception The exception thrown during processing of this record.
Null if no error occurred.
*/
- void onAcknowledgement(RecordMetadata metadata, Exception exception);
+ default void onAcknowledgement(RecordMetadata metadata, Exception
exception) {}
+
+ /**
+ * This method is called when the record sent to the server has been
acknowledged, or when sending the record fails before
+ * it gets sent to the server.
+ * <p>
+ * This method is called just before the user callback is invoked, or in
cases when
+ * <code>KafkaProducer.send()</code> throws an exception.
+ * throws an exception.
+ * <p>
+ * Note that any exception thrown by this method will be ignored by the
caller.
+ * <p>
+ * The implementation of this method should be fast as it generally
executes in a background
+ * I/O thread. A slow implementation could delay the sending of messages
from other threads.
+
+ * Otherwise, sending of messages from other threads could be delayed.
+ *
+ * @param metadata The metadata for the record that was sent (i.e. the
partition and offset).
+ * If an error occurred, metadata will contain only valid
topic and maybe
+ * partition. If partition is not given in ProducerRecord
and an error occurs
+ * before partition gets assigned, then partition will be
set to RecordMetadata.UNKNOWN_PARTITION.
+ * The metadata may be null if the client passed null
record to
+ * {@link
org.apache.kafka.clients.producer.KafkaProducer#send(ProducerRecord)}.
+ * @param exception The exception thrown during processing of this record.
Null if no error occurred.
+ * @param headers The headers for the record that was sent. This parameter
may be null.
Review Comment:
Since `ProducerRecord#header` is never null, it would be more appropriate to
pass an empty header rather than null. This aligns with the existing behavior
and avoids introducing unnecessary null checks. WDYT?
https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java#L83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
