Re: [PR] KAFKA-10790: Add deadlock detection to producer#flush [kafka]

[via GitHub]

AndrewJSchofield commented on code in PR #17946:
URL: https://github.com/apache/kafka/pull/17946#discussion_r1862694227


##########
docs/upgrade.html:
##########
@@ -142,6 +142,8 @@ <h5><a id="upgrade_400_notable" 
href="#upgrade_400_notable">Notable changes in 4
                         </li>
                         <li>The deprecated 
<code>sendOffsetsToTransaction(Map&lt;TopicPartition, OffsetAndMetadata&gt;, 
String)</code> method has been removed from the Producer API.
                         </li>
+                        <li>The <code>flush</code> method now includes 
deadlock detection when invoked inside a callback to prevent unintended 
blocking scenarios.

Review Comment:
   This could be more explicit, like the message in the exception added to 
`KafkaProducer`. You are not allowed to use `flush()` in the callback. Maybe 
"The flush method now includes deadlock detection preventing its use inside a 
callback. This avoids unintended blocking which has been known to occur prior 
to this change." Something like that. We want someone reading this to 
understand that they must not use flush in the callback.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org