dajac commented on code in PR #17951:
URL: https://github.com/apache/kafka/pull/17951#discussion_r1860390536
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractHeartbeatRequestManager.java:
##########
@@ -406,6 +406,12 @@ private void onErrorResponse(final R response, final long
currentTimeMs) {
heartbeatRequestState.reset();
break;
+ case INVALID_REGULAR_EXPRESSION:
+ logger.error("{} failed due to {}: {}",
heartbeatRequestName(), error, errorMessage);
+ handleFatalFailure(error.exception("The SubscriptionPattern
provided in the call to subscribe is not " +
+ "a valid RE2J regular expression."));
Review Comment:
nit: Could we include the actual pattern in the error? I also wonder if we
could also include the error received from the server because it includes the
reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
