chia7712 commented on code in PR #17913:
URL: https://github.com/apache/kafka/pull/17913#discussion_r1855184839
##########
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala:
##########
@@ -152,10 +142,6 @@ class ServerShutdownTest extends KafkaServerTestHarness {
shutdownBroker()
shutdownKRaftController()
verifyCleanShutdownAfterFailedStartup[CancellationException]
- } else {
Review Comment:
ditto. could you please remove `isKRaftTest`?
##########
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala:
##########
@@ -327,22 +253,6 @@ class DynamicConfigChangeTest extends
KafkaServerTestHarness {
} finally {
admin.close()
}
- } else {
Review Comment:
Could you please also remove `if (isKRaftTest())` for this test? It is
redundant now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
