FrankYang0529 opened a new pull request, #17907: URL: https://github.com/apache/kafka/pull/17907
In [KIP-853](https://cwiki.apache.org/confluence/display/KAFKA/KIP-853%3A+KRaft+Controller+Membership+Changes), it uses following command as adding controller example. ``` kafka-metadata-quorum --bootstrap-server <endpoints> add-controller --config controller.properties ``` The script returns "kafka-metadata-quorum: error: unrecognized arguments: '--config'". The correct way to add controller is like following: ``` kafka-metadata-quorum --bootstrap-server <endpoints> --command-config controller.properties add-controller ``` From @chia7712's [suggestion](https://issues.apache.org/jira/browse/KAFKA-18059?focusedCommentId=17899998&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17899998), we keep using `--command-config` to avoid breaking change. However, in `MetadataQuorumCommand`, the `--command-config` description is "Property file containing configs to be passed to Admin Client.". We should update the description to mention it's also used as controller property file for `add-controller` command. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
