mimaison commented on code in PR #17880:
URL: https://github.com/apache/kafka/pull/17880#discussion_r1850686209
##########
tools/src/test/java/org/apache/kafka/tools/AclCommandTest.java:
##########
@@ -355,7 +346,7 @@ public void testInvalidArgs() {
"Option \"[list]\" can't be used with option \"[producer]\""
);
assertInitializeInvalidOptionsExitCodeAndMsg(
- Arrays.asList(BOOTSTRAP_SERVER, LOCALHOST, ADD, PRODUCER,
OPERATION),
+ Arrays.asList(BOOTSTRAP_SERVER, LOCALHOST, ADD, PRODUCER,
OPERATION, "all"),
Review Comment:
Running the same command on the CLI did not produce that error message, so
this test was effectively testing internal logic that would not be reachable
for users.
```
./bin/kafka-acls.sh --bootstrap-server localhost:9092 --add --producer
--operation
Exception in thread "main"
joptsimple.OptionMissingRequiredArgumentException: Option operation requires an
argument
```
To produce that error message from the CLI you need to specify an operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
