AndrewJSchofield commented on code in PR #17739:
URL: https://github.com/apache/kafka/pull/17739#discussion_r1842640545
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1602,8 +1602,6 @@ protected void
updateFetchOffsetMetadata(Optional<LogOffsetMetadata> fetchOffset
protected Optional<LogOffsetMetadata> fetchOffsetMetadata() {
lock.readLock().lock();
try {
- if (findNextFetchOffset.get())
Review Comment:
Clearly, I don't understand the details of this interface, but one assertion
jumped out as strange. The user doesn't get to initialize an arbitrary offset
in the middle of a batch. We are in total control of the offset. The scheme
which @junrao described will surely work, but I wanted to confirm whether it's
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
