matt-welch commented on code in PR #17340:
URL: https://github.com/apache/kafka/pull/17340#discussion_r1838628246
##########
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##########
@@ -114,6 +133,10 @@ record = new ProducerRecord<>(config.topicName, payload);
if (!config.shouldPrintMetrics) {
producer.close();
+ /* print warmup stats if relevant */
+ if (warmupStats != null) {
+ new Stats(warmupStats, stats).printTotal();
Review Comment:
Thanks for the review @chia7712!
Just to be clear, are you suggesting that, instead of using a warmup stats
followed by a steady state stats object, we should use a whole-test stats
object in addition to a steady-state stats object?
I don't see any serious issues in the implementation, but I the producer
callback will need refactoring so it writes into two stats objects once steady
state has triggered. In the initial design, I was trying to avoid this
concurrent need for both stats objects and do the array-merging at the end, but
I will give it a try to see how it looks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
