apoorvmittal10 commented on code in PR #17709:
URL: https://github.com/apache/kafka/pull/17709#discussion_r1834553884
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -296,15 +296,15 @@ private boolean isMinBytesSatisfied(Map<TopicIdPartition,
FetchRequest.Partition
}
}
}
- return accumulatedSize >= shareFetchData.fetchParams().minBytes;
+ return accumulatedSize >= shareFetch.fetchParams().minBytes;
}
private LogOffsetMetadata
endOffsetMetadataForTopicPartition(TopicIdPartition topicIdPartition) {
Partition partition =
replicaManager.getPartitionOrException(topicIdPartition.topicPartition());
LogOffsetSnapshot offsetSnapshot =
partition.fetchOffsetSnapshot(Optional.empty(), true);
// The FetchIsolation type that we use for share fetch is
FetchIsolation.HIGH_WATERMARK. In the future, we can
// extend it to support other FetchIsolation types.
- FetchIsolation isolationType = shareFetchData.fetchParams().isolation;
+ FetchIsolation isolationType = shareFetch.fetchParams().isolation;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
