OmniaGM commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r1831243586
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -866,17 +872,17 @@ class ReplicaManager(val config: KafkaConfig,
s"Unable to verify the partition has been added to the
transaction. Underlying error: ${error.toString}"))
case _ => None
}
- topicPartition -> LogAppendResult(
+ new TopicIdPartition(topicIds.getOrElse(topicPartition.topic(),
Uuid.ZERO_UUID), topicPartition) -> LogAppendResult(
LogAppendInfo.UNKNOWN_LOG_APPEND_INFO,
Some(customException.getOrElse(error.exception)),
hasCustomErrorMessage = customException.isDefined
)
}
- val entriesWithoutErrorsPerPartition = entriesPerPartition.filter { case
(key, _) => !errorResults.contains(key) }
+ val entriesWithoutErrorsPerPartition = entriesPerPartition.filter { case
(key, _) => !errorResults.exists(_._1.topicPartition() == key.topicPartition())
}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
